--- np2/i386c/ia32/task.c	2011/12/20 09:03:28	1.27
+++ np2/i386c/ia32/task.c	2011/12/23 04:16:51	1.29
@@ -203,8 +203,7 @@ task_switch(selector_t *task_sel, task_s
 	UINT16 t;
 	int new_cpl;
 
-	selector_t sreg_sel[CPU_SEGREG_NUM];
-	selector_t ldtr_sel;
+	selector_t cs_sel, ss_sel;
 	int rv;
 
 	UINT32 cur_base, cur_paddr;	/* current task state */
@@ -438,40 +437,29 @@ task_switch(selector_t *task_sel, task_s
 	CPU_CR0 |= CPU_CR0_TS;
 
 	/*
-	 * load task state (EIP, GPR, EFLAG, segreg, CR3, LDTR)
+	 * load task state (CR3, EIP, GPR, segregs, LDTR, EFLAGS)
 	 */
 
-	/* set new EIP, GPR */
+	/* set new CR3 */
+	if (!task16 && CPU_STAT_PAGING) {
+		set_cr3(cr3);
+	}
+
+	/* set new EIP, GPR, segregs */
 	CPU_EIP = eip;
 	for (i = 0; i < CPU_REG_NUM; i++) {
 		CPU_REGS_DWORD(i) = regs[i];
 	}
-
-	CPU_CLEAR_PREV_ESP();
-
-	/* set new EFLAGS */
-	set_eflags(new_flags, I_FLAG|IOPL_FLAG|RF_FLAG|VM_FLAG|VIF_FLAG|VIP_FLAG);
-
-	/* check new segregs, ldtr */
 	for (i = 0; i < CPU_SEGREG_NUM; i++) {
-		rv = parse_selector(&sreg_sel[i], sreg[i]);
-		if (rv < 0) {
-			VERBOSE(("task_switch: selector parse failure: index=%d (sel = 0x%04x, rv = %d)", i, sreg[i], rv));
-			EXCEPTION(TS_EXCEPTION, sreg_sel[i].idx);
-		}
-	}
-	rv = parse_selector(&ldtr_sel, ldtr);
-	if (rv < 0) {
-		VERBOSE(("task_switch: LDTR selector parse failure (sel = 0x%04x, rv = %d)", ldtr, rv));
-		EXCEPTION(TS_EXCEPTION, ldtr_sel.idx);
+		segdesc_init(i, sreg[i], &CPU_STAT_SREG(i));
+		/* invalidate segreg descriptor */
+		CPU_STAT_SREG(i).valid = 0;
 	}
 
-	/* set new CR3 */
-	if (!task16 && CPU_STAT_PAGING) {
-		set_cr3(cr3);
-	}
+	CPU_CLEAR_PREV_ESP();
 
 	/* load new LDTR */
+	CPU_LDTR_DESC.valid = 0;
 	load_ldtr(ldtr, TS_EXCEPTION);
 
 	/* I/O deny bitmap */
@@ -498,87 +486,79 @@ task_switch(selector_t *task_sel, task_s
 	}
 #endif
 
+	/* set new EFLAGS */
+	set_eflags(new_flags, I_FLAG|IOPL_FLAG|RF_FLAG|VM_FLAG|VIF_FLAG|VIP_FLAG);
+
 	/* set new segment register */
-	new_cpl = sreg_sel[CPU_CS_INDEX].rpl;
-	if (CPU_STAT_VM86) {
-		load_ss(sreg_sel[CPU_SS_INDEX].selector,
-		    &sreg_sel[CPU_SS_INDEX].desc, new_cpl);
-		LOAD_SEGREG1(CPU_ES_INDEX, sreg_sel[CPU_ES_INDEX].selector,
-		    TS_EXCEPTION);
-		LOAD_SEGREG1(CPU_DS_INDEX, sreg_sel[CPU_DS_INDEX].selector,
-		    TS_EXCEPTION);
-		LOAD_SEGREG1(CPU_FS_INDEX, sreg_sel[CPU_FS_INDEX].selector,
-		    TS_EXCEPTION);
-		LOAD_SEGREG1(CPU_GS_INDEX, sreg_sel[CPU_GS_INDEX].selector,
-		    TS_EXCEPTION);
-		load_cs(sreg_sel[CPU_CS_INDEX].selector,
-		    &sreg_sel[CPU_CS_INDEX].desc, new_cpl);
-	} else {
+	if (!CPU_STAT_VM86) {
 		/* load SS */
+		rv = parse_selector(&ss_sel, sreg[CPU_SS_INDEX]);
+		if (rv < 0) {
+			VERBOSE(("task_switch: load SS failure (sel = 0x%04x, rv = %d)", sreg[CPU_SS_INDEX], rv));
+			EXCEPTION(TS_EXCEPTION, ss_sel.idx);
+		}
 
 		/* SS must be writable data segment */
-		if (SEG_IS_SYSTEM(&sreg_sel[CPU_SS_INDEX].desc)
-		 || SEG_IS_CODE(&sreg_sel[CPU_SS_INDEX].desc)
-		 || !SEG_IS_WRITABLE_DATA(&sreg_sel[CPU_SS_INDEX].desc)) {
-			EXCEPTION(TS_EXCEPTION, sreg_sel[CPU_SS_INDEX].idx);
+		if (SEG_IS_SYSTEM(&ss_sel.desc)
+		 || SEG_IS_CODE(&ss_sel.desc)
+		 || !SEG_IS_WRITABLE_DATA(&ss_sel.desc)) {
+			EXCEPTION(TS_EXCEPTION, ss_sel.idx);
 		}
 
 		/* check privilege level */
-		if ((sreg_sel[CPU_SS_INDEX].desc.dpl != new_cpl)
-		 || (sreg_sel[CPU_SS_INDEX].desc.dpl != new_cpl)) {
-			EXCEPTION(TS_EXCEPTION, sreg_sel[CPU_SS_INDEX].idx);
+		if ((ss_sel.desc.dpl != cs_sel.rpl)
+		 || (ss_sel.desc.dpl != ss_sel.rpl)) {
+			EXCEPTION(TS_EXCEPTION, ss_sel.idx);
 		}
 
 		/* stack segment is not present */
-		rv = selector_is_not_present(&sreg_sel[CPU_SS_INDEX]);
+		rv = selector_is_not_present(&ss_sel);
 		if (rv < 0) {
-			EXCEPTION(SS_EXCEPTION, sreg_sel[CPU_SS_INDEX].idx);
+			EXCEPTION(SS_EXCEPTION, ss_sel.idx);
 		}
 
 		/* Now loading SS register */
-		load_ss(sreg_sel[CPU_SS_INDEX].selector,
-		    &sreg_sel[CPU_SS_INDEX].desc, new_cpl);
+		load_ss(ss_sel.selector, &ss_sel.desc, cs_sel.rpl);
 
 		/* load ES, DS, FS, GS segment register */
-		LOAD_SEGREG1(CPU_ES_INDEX, sreg_sel[CPU_ES_INDEX].selector,
-		    TS_EXCEPTION);
-		LOAD_SEGREG1(CPU_DS_INDEX, sreg_sel[CPU_DS_INDEX].selector,
-		    TS_EXCEPTION);
-		LOAD_SEGREG1(CPU_FS_INDEX, sreg_sel[CPU_FS_INDEX].selector,
-		    TS_EXCEPTION);
-		LOAD_SEGREG1(CPU_GS_INDEX, sreg_sel[CPU_GS_INDEX].selector,
-		    TS_EXCEPTION);
+		LOAD_SEGREG1(CPU_ES_INDEX, sreg[CPU_ES_INDEX], TS_EXCEPTION);
+		LOAD_SEGREG1(CPU_DS_INDEX, sreg[CPU_DS_INDEX], TS_EXCEPTION);
+		LOAD_SEGREG1(CPU_FS_INDEX, sreg[CPU_FS_INDEX], TS_EXCEPTION);
+		LOAD_SEGREG1(CPU_GS_INDEX, sreg[CPU_GS_INDEX], TS_EXCEPTION);
 
 		/* load CS */
+		rv = parse_selector(&cs_sel, sreg[CPU_CS_INDEX]);
+		if (rv < 0) {
+			VERBOSE(("task_switch: load CS failure (sel = 0x%04x, rv = %d)", sreg[CPU_CS_INDEX], rv));
+			EXCEPTION(TS_EXCEPTION, cs_sel.idx);
+		}
 
 		/* CS must be code segment */
-		if (SEG_IS_SYSTEM(&sreg_sel[CPU_CS_INDEX].desc)
-		 || SEG_IS_DATA(&sreg_sel[CPU_CS_INDEX].desc)) {
-			EXCEPTION(TS_EXCEPTION, sreg_sel[CPU_CS_INDEX].idx);
+		if (SEG_IS_SYSTEM(&cs_sel.desc) || SEG_IS_DATA(&cs_sel.desc)) {
+			EXCEPTION(TS_EXCEPTION, cs_sel.idx);
 		}
 
 		/* check privilege level */
-		if (!SEG_IS_CONFORMING_CODE(&sreg_sel[CPU_CS_INDEX].desc)) {
+		if (!SEG_IS_CONFORMING_CODE(&cs_sel.desc)) {
 			/* non-confirming code segment */
-			if (sreg_sel[CPU_CS_INDEX].desc.dpl != new_cpl) {
-				EXCEPTION(TS_EXCEPTION, sreg_sel[CPU_CS_INDEX].idx);
+			if (cs_sel.desc.dpl != cs_sel.rpl) {
+				EXCEPTION(TS_EXCEPTION, cs_sel.idx);
 			}
 		} else {
 			/* conforming code segment */
-			if (sreg_sel[CPU_CS_INDEX].desc.dpl > new_cpl) {
-				EXCEPTION(TS_EXCEPTION, sreg_sel[CPU_CS_INDEX].idx);
+			if (cs_sel.desc.dpl > cs_sel.rpl) {
+				EXCEPTION(TS_EXCEPTION, cs_sel.idx);
 			}
 		}
 
 		/* code segment is not present */
-		rv = selector_is_not_present(&sreg_sel[CPU_CS_INDEX]);
+		rv = selector_is_not_present(&cs_sel);
 		if (rv < 0) {
-			EXCEPTION(NP_EXCEPTION, sreg_sel[CPU_CS_INDEX].idx);
+			EXCEPTION(NP_EXCEPTION, cs_sel.idx);
 		}
 
 		/* Now loading CS register */
-		load_cs(sreg_sel[CPU_CS_INDEX].selector,
-		    &sreg_sel[CPU_CS_INDEX].desc, new_cpl);
+		load_cs(cs_sel.selector, &cs_sel.desc, cs_sel.rpl);
 	}
 
 	VERBOSE(("task_switch: done."));