--- np2/x11/gtk2/gtk_menu.c 2008/04/03 13:53:25 1.14 +++ np2/x11/gtk2/gtk_menu.c 2011/12/17 16:20:05 1.22 @@ -1,5 +1,3 @@ -/* $Id: gtk_menu.c,v 1.14 2008/04/03 13:53:25 monaka Exp $ */ - /* * Copyright (c) 2004 NONAKA Kimihiro (aw9k-nnk@asahi-net.or.jp) * All rights reserved. @@ -564,9 +562,6 @@ cb_bmpsave(GtkAction *action, gpointer u SCRNBMP bmp = NULL; FILEH fh; - UNUSED(action); - UNUSED(user_data); - uninstall_idle_process(); bmp = scrnbmp(); @@ -581,8 +576,11 @@ cb_bmpsave(GtkAction *action, gpointer u if (dialog == NULL) goto end; - g_object_set(G_OBJECT(dialog), "show-hidden", TRUE, NULL); - gtk_file_chooser_set_select_multiple(GTK_FILE_CHOOSER(dialog), FALSE); + gtk_file_chooser_set_show_hidden(GTK_FILE_CHOOSER(dialog), TRUE); +#if iGTK_MAJOR_VERSION >= 2 && GTK_MINOR_VERSION >= 8 + gtk_file_chooser_set_do_overwrite_confirmation(GTK_FILE_CHOOSER(dialog), + TRUE); +#endif if (strlen(bmpfilefolder) == 0) { g_strlcpy(bmpfilefolder, modulefile, sizeof(bmpfilefolder)); file_cutname(bmpfilefolder); @@ -614,6 +612,12 @@ cb_bmpsave(GtkAction *action, gpointer u if (utf8) { path = g_filename_from_utf8(utf8, -1, NULL, NULL, NULL); if (path) { + gchar *ext = file_getext(path); + if (strlen(ext) != 3 || file_cmpname(ext, "bmp")) { + gchar *tmp = g_strjoin(".", path, "bmp", NULL); + g_free(path); + path = tmp; + } file_cpyname(bmpfilefolder, path, sizeof(bmpfilefolder)); sysmng_update(SYS_UPDATEOSCFG); fh = file_create(path); @@ -642,9 +646,6 @@ cb_change_font(GtkAction *action, gpoint gchar *utf8, *path; struct stat sb; - UNUSED(action); - UNUSED(user_data); - uninstall_idle_process(); dialog = gtk_file_chooser_dialog_new("Open a font file", @@ -655,8 +656,7 @@ cb_change_font(GtkAction *action, gpoint if (dialog == NULL) goto end; - g_object_set(G_OBJECT(dialog), "show-hidden", TRUE, NULL); - gtk_file_chooser_set_select_multiple(GTK_FILE_CHOOSER(dialog), FALSE); + gtk_file_chooser_set_show_hidden(GTK_FILE_CHOOSER(dialog), TRUE); utf8 = g_filename_to_utf8(np2cfg.fontfile, -1, NULL, NULL, NULL); if (utf8) { gtk_file_chooser_set_filename(GTK_FILE_CHOOSER(dialog), utf8); @@ -708,8 +708,6 @@ cb_diskeject(GtkAction *action, gpointer const gchar *name = gtk_action_get_name(action); guint drive; - UNUSED(user_data); - /* name = "disk?eject" */ if ((strlen(name) >= 5) && (g_ascii_isdigit(name[4]))) { drive = g_ascii_digit_value(name[4]) - 1; @@ -730,8 +728,6 @@ cb_diskopen(GtkAction *action, gpointer const gchar *name = gtk_action_get_name(action); guint drive; - UNUSED(user_data); - if ((strlen(name) < 5) || (!g_ascii_isdigit(name[4]))) return; drive = g_ascii_digit_value(name[4]) - 1; @@ -746,8 +742,7 @@ cb_diskopen(GtkAction *action, gpointer if (dialog == NULL) goto end; - g_object_set(G_OBJECT(dialog), "show-hidden", TRUE, NULL); - gtk_file_chooser_set_select_multiple(GTK_FILE_CHOOSER(dialog), FALSE); + gtk_file_chooser_set_show_hidden(GTK_FILE_CHOOSER(dialog), TRUE); utf8 = g_filename_to_utf8(fddfolder, -1, NULL, NULL, NULL); if (utf8) { gtk_file_chooser_set_filename(GTK_FILE_CHOOSER(dialog), utf8); @@ -833,8 +828,6 @@ cb_ataopen(GtkAction *action, gpointer u const gchar *name = gtk_action_get_name(action); guint channel, drive; - UNUSED(user_data); - /* "ata??open" */ if ((strlen(name) < 5) || (!g_ascii_isdigit(name[3])) @@ -857,8 +850,7 @@ cb_ataopen(GtkAction *action, gpointer u if (dialog == NULL) goto end; - g_object_set(G_OBJECT(dialog), "show-hidden", TRUE, NULL); - gtk_file_chooser_set_select_multiple(GTK_FILE_CHOOSER(dialog), FALSE); + gtk_file_chooser_set_show_hidden(GTK_FILE_CHOOSER(dialog), TRUE); utf8 = g_filename_to_utf8(hddfolder, -1, NULL, NULL, NULL); if (utf8) { gtk_file_chooser_set_filename(GTK_FILE_CHOOSER(dialog), utf8); @@ -910,8 +902,6 @@ cb_ataremove(GtkAction *action, gpointer const gchar *name = gtk_action_get_name(GTK_ACTION(action)); guint channel, drive; - UNUSED(user_data); - /* "ata??open" */ if ((strlen(name) < 5) || (!g_ascii_isdigit(name[3])) @@ -936,9 +926,6 @@ cb_atapiopen(GtkAction *action, gpointer gchar *utf8, *path; struct stat sb; - UNUSED(action); - UNUSED(user_data); - uninstall_idle_process(); dialog = gtk_file_chooser_dialog_new("Open a ATAPI CD-ROM image", @@ -949,8 +936,7 @@ cb_atapiopen(GtkAction *action, gpointer if (dialog == NULL) goto end; - g_object_set(G_OBJECT(dialog), "show-hidden", TRUE, NULL); - gtk_file_chooser_set_select_multiple(GTK_FILE_CHOOSER(dialog), FALSE); + gtk_file_chooser_set_show_hidden(GTK_FILE_CHOOSER(dialog), TRUE); utf8 = g_filename_to_utf8(hddfolder, -1, NULL, NULL, NULL); if (utf8) { gtk_file_chooser_set_filename(GTK_FILE_CHOOSER(dialog), utf8); @@ -1004,9 +990,6 @@ static void cb_atapiremove(GtkAction *action, gpointer user_data) { - UNUSED(action); - UNUSED(user_data); - sxsi_devclose(0x02); } #endif /* SUPPORT_IDEIO */ @@ -1015,9 +998,6 @@ static void cb_midipanic(GtkAction *action, gpointer user_data) { - UNUSED(action); - UNUSED(user_data); - rs232c_midipanic(); mpu98ii_midipanic(); pc9861k_midipanic(); @@ -1046,9 +1026,6 @@ cb_newdisk(GtkAction *action, gpointer u int kind; int i; - UNUSED(action); - UNUSED(user_data); - uninstall_idle_process(); dialog = gtk_file_chooser_dialog_new("Create new disk image file", @@ -1059,8 +1036,11 @@ cb_newdisk(GtkAction *action, gpointer u if (dialog == NULL) goto end; - g_object_set(G_OBJECT(dialog), "show-hidden", TRUE, NULL); - gtk_file_chooser_set_select_multiple(GTK_FILE_CHOOSER(dialog), FALSE); + gtk_file_chooser_set_show_hidden(GTK_FILE_CHOOSER(dialog), TRUE); +#if iGTK_MAJOR_VERSION >= 2 && GTK_MINOR_VERSION >= 8 + gtk_file_chooser_set_do_overwrite_confirmation(GTK_FILE_CHOOSER(dialog), + TRUE); +#endif if (strlen(fddfolder) == 0) { g_strlcpy(fddfolder, modulefile, sizeof(fddfolder)); file_cutname(fddfolder); @@ -1172,9 +1152,6 @@ static void cb_reset(GtkAction *action, gpointer user_data) { - UNUSED(action); - UNUSED(user_data); - pccore_cfgupdate(); pccore_reset(); } @@ -1190,8 +1167,6 @@ cb_sasiopen(GtkAction *action, gpointer const gchar *name = gtk_action_get_name(action); guint drive; - UNUSED(user_data); - if ((strlen(name) < 5) || (!g_ascii_isdigit(name[4]))) return; drive = g_ascii_digit_value(name[4]) - 1; @@ -1206,8 +1181,7 @@ cb_sasiopen(GtkAction *action, gpointer if (dialog == NULL) goto end; - g_object_set(G_OBJECT(dialog), "show-hidden", TRUE, NULL); - gtk_file_chooser_set_select_multiple(GTK_FILE_CHOOSER(dialog), FALSE); + gtk_file_chooser_set_show_hidden(GTK_FILE_CHOOSER(dialog), TRUE); utf8 = g_filename_to_utf8(hddfolder, -1, NULL, NULL, NULL); if (utf8) { gtk_file_chooser_set_filename(GTK_FILE_CHOOSER(dialog), utf8); @@ -1259,8 +1233,6 @@ cb_sasiremove(GtkAction *action, gpointe const gchar *name = gtk_action_get_name(GTK_ACTION(action)); guint drive; - UNUSED(user_data); - /* name = "sasi?eject" */ if ((strlen(name) >= 5) && (g_ascii_isdigit(name[4]))) { drive = g_ascii_digit_value(name[4]) - 1; @@ -1279,8 +1251,6 @@ cb_statsave(GtkAction *action, gpointer char ext[4]; guint n; - UNUSED(user_data); - /* name = "stat??save" */ if ((strlen(name) >= 6) && (g_ascii_isdigit(name[4])) @@ -1299,8 +1269,6 @@ cb_statload(GtkAction *action, gpointer char ext[4]; guint n; - UNUSED(user_data); - /* name = "stat??load" */ if ((strlen(name) >= 6) && (g_ascii_isdigit(name[4])) @@ -1318,8 +1286,6 @@ cb_dialog(GtkAction *action, gpointer us { const gchar *name = gtk_action_get_name(action); - UNUSED(user_data); - if (g_ascii_strcasecmp(name, "configure") == 0) { create_configure_dialog(); } else if (g_ascii_strcasecmp(name, "soundopt") == 0) { @@ -1346,8 +1312,6 @@ cb_clockdisp(GtkToggleAction *action, gp gboolean b = gtk_toggle_action_get_active(action); gboolean f; - UNUSED(user_data); - f = (np2oscfg.DISPCLK & 1) ^ (b ? 1 : 0); if (f) { np2oscfg.DISPCLK ^= 1; @@ -1363,8 +1327,6 @@ cb_dispvsync(GtkToggleAction *action, gp gboolean b = gtk_toggle_action_get_active(action); gboolean f; - UNUSED(user_data); - f = (np2cfg.DISPSYNC ? 1 : 0) ^ (b ? 1 : 0); if (f) { np2cfg.DISPSYNC = !np2cfg.DISPSYNC; @@ -1378,8 +1340,6 @@ cb_framedisp(GtkToggleAction *action, gp gboolean b = gtk_toggle_action_get_active(action); gboolean f; - UNUSED(user_data); - f = (np2oscfg.DISPCLK & 2) ^ (b ? 2 : 0); if (f) { np2oscfg.DISPCLK ^= 2; @@ -1395,8 +1355,6 @@ cb_jastsound(GtkToggleAction *action, gp gboolean b = gtk_toggle_action_get_active(action); gboolean f; - UNUSED(user_data); - f = (np2oscfg.jastsnd ? 1 : 0) ^ (b ? 1 : 0); if (f) { np2oscfg.jastsnd = !np2oscfg.jastsnd; @@ -1410,8 +1368,6 @@ cb_joyrapid(GtkToggleAction *action, gpo gboolean b = gtk_toggle_action_get_active(action); gboolean f; - UNUSED(user_data); - f = (np2cfg.BTN_RAPID ? 1 : 0) ^ (b ? 1 : 0); if (f) { np2cfg.BTN_RAPID = !np2cfg.BTN_RAPID; @@ -1425,8 +1381,6 @@ cb_joyreverse(GtkToggleAction *action, g gboolean b = gtk_toggle_action_get_active(action); gboolean f; - UNUSED(user_data); - f = (np2cfg.BTN_MODE ? 1 : 0) ^ (b ? 1 : 0); if (f) { np2cfg.BTN_MODE = !np2cfg.BTN_MODE; @@ -1440,8 +1394,6 @@ cb_keydisplay(GtkToggleAction *action, g gboolean b = gtk_toggle_action_get_active(action); gboolean f; - UNUSED(user_data); - f = (np2oscfg.keydisp ? 1 : 0) ^ (b ? 1 : 0); if (f) { np2oscfg.keydisp = !np2oscfg.keydisp; @@ -1460,8 +1412,6 @@ cb_mousemode(GtkToggleAction *action, gp gboolean b = gtk_toggle_action_get_active(action); gboolean f; - UNUSED(user_data); - f = (np2oscfg.MOUSE_SW ? 1 : 0) ^ (b ? 1 : 0); if (f) { mouse_running(MOUSE_XOR); @@ -1476,8 +1426,6 @@ cb_mouserapid(GtkToggleAction *action, g gboolean b = gtk_toggle_action_get_active(action); gboolean f; - UNUSED(user_data); - f = (np2cfg.MOUSERAPID ? 1 : 0) ^ (b ? 1 : 0); if (f) { np2cfg.MOUSERAPID = !np2cfg.MOUSERAPID; @@ -1491,8 +1439,6 @@ cb_nowait(GtkToggleAction *action, gpoin gboolean b = gtk_toggle_action_get_active(action); gboolean f; - UNUSED(user_data); - f = (np2oscfg.NOWAIT ? 1 : 0) ^ (b ? 1 : 0); if (f) { np2oscfg.NOWAIT = !np2oscfg.NOWAIT; @@ -1506,8 +1452,6 @@ cb_realpalettes(GtkToggleAction *action, gboolean b = gtk_toggle_action_get_active(action); gboolean f; - UNUSED(user_data); - f = (np2cfg.RASTER ? 1 : 0) ^ (b ? 1 : 0); if (f) { np2cfg.RASTER = !np2cfg.RASTER; @@ -1523,8 +1467,6 @@ cb_s98logging(GtkToggleAction *action, g gboolean b = gtk_toggle_action_get_active(action); gboolean f; - UNUSED(user_data); - f = (s98logging ? 1 : 0) ^ (b ? 1 : 0); if (f) { s98logging = !s98logging; @@ -1546,8 +1488,6 @@ cb_seeksound(GtkToggleAction *action, gp gboolean b = gtk_toggle_action_get_active(action); gboolean f; - UNUSED(user_data); - f = (np2cfg.MOTOR ? 1 : 0) ^ (b ? 1 : 0); if (f) { np2cfg.MOTOR = !np2cfg.MOTOR; @@ -1561,8 +1501,6 @@ cb_softkeyboard(GtkToggleAction *action, gboolean b = gtk_toggle_action_get_active(action); gboolean f; - UNUSED(user_data); - f = (np2oscfg.softkbd ? 1 : 0) ^ (b ? 1 : 0); if (f) { np2oscfg.softkbd = !np2oscfg.softkbd; @@ -1581,8 +1519,6 @@ cb_toolwindow(GtkToggleAction *action, g gboolean b = gtk_toggle_action_get_active(action); gboolean f; - UNUSED(user_data); - f = (np2oscfg.toolwin ? 1 : 0) ^ (b ? 1 : 0); if (f) { np2oscfg.toolwin = !np2oscfg.toolwin; @@ -1601,8 +1537,6 @@ cb_xctrlkey(GtkToggleAction *action, gpo gboolean b = gtk_toggle_action_get_active(action); gboolean f; - UNUSED(user_data); - f = (np2cfg.XSHIFT & 2) ^ (b ? 2 : 0); if (f) { np2cfg.XSHIFT ^= 2; @@ -1617,8 +1551,6 @@ cb_xgrphkey(GtkToggleAction *action, gpo gboolean b = gtk_toggle_action_get_active(action); gboolean f; - UNUSED(user_data); - f = (np2cfg.XSHIFT & 4) ^ (b ? 4 : 0); if (f) { np2cfg.XSHIFT ^= 4; @@ -1633,8 +1565,6 @@ cb_xshiftkey(GtkToggleAction *action, gp gboolean b = gtk_toggle_action_get_active(action); gboolean f; - UNUSED(user_data); - f = (np2cfg.XSHIFT & 1) ^ (b ? 1 : 0); if (f) { np2cfg.XSHIFT ^= 1; @@ -1792,8 +1722,6 @@ cb_radio(GtkRadioAction *action, GtkRadi guint menu_idx = (guint)GPOINTER_TO_INT(user_data); gint i; - UNUSED(current); /* emitted item */ - if (menu_idx < n_radiomenu_entries) { for (i = 0; i < radiomenu_entries[menu_idx].count; i++) { if (radiomenu_entries[menu_idx].entry[i].value == value) @@ -1821,8 +1749,6 @@ static gboolean menubar_timeout(gpointer p) { - UNUSED(p); - if (menubar_timerid) { g_source_remove(menubar_timerid); menubar_timerid = 0; @@ -1843,10 +1769,6 @@ static gboolean enter_notify_evhandler(GtkWidget *w, GdkEventCrossing *ev, gpointer p) { - UNUSED(w); - UNUSED(ev); - UNUSED(p); - if (menubar_timerid) { g_source_remove(menubar_timerid); menubar_timerid = 0; @@ -1863,10 +1785,6 @@ static gboolean leave_notify_evhandler(GtkWidget *w, GdkEventCrossing *ev, gpointer p) { - UNUSED(w); - UNUSED(ev); - UNUSED(p); - if (menubar_timerid) { g_source_remove(menubar_timerid); menubar_timerid = 0; @@ -2037,9 +1955,9 @@ create_menu(void) gtk_widget_add_events(menubar, EVENT_MASK); g_signal_connect(GTK_OBJECT(menubar), "enter_notify_event", - GTK_SIGNAL_FUNC(enter_notify_evhandler), NULL); + G_CALLBACK(enter_notify_evhandler), NULL); g_signal_connect(GTK_OBJECT(menubar), "leave_notify_event", - GTK_SIGNAL_FUNC(leave_notify_evhandler), NULL); + G_CALLBACK(leave_notify_evhandler), NULL); return menubar; } @@ -2062,7 +1980,7 @@ void xmenu_toggle_menu(void) { - if (GTK_WIDGET_VISIBLE(menubar)) + if (gtk_widget_get_visible(menubar)) xmenu_hide(); else xmenu_show();